From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com ([141.146.126.69]:40897 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935507AbcIFRfO (ORCPT ); Tue, 6 Sep 2016 13:35:14 -0400 Date: Tue, 6 Sep 2016 10:34:28 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: Christoph Hellwig , david@fromorbit.com, viro@ZenIV.linux.org.uk, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, linux-api@vger.kernel.org Subject: Re: [PATCH 4/6] fs: add iomap_file_dirty Message-ID: <20160906173428.GG16696@birch.djwong.org> References: <147216784041.525.7722906502172299465.stgit@birch.djwong.org> <147216786712.525.5901639662288553230.stgit@birch.djwong.org> <20160905145751.GC7662@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160905145751.GC7662@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Sep 05, 2016 at 07:57:51AM -0700, Christoph Hellwig wrote: > On Thu, Aug 25, 2016 at 04:31:07PM -0700, Christoph Hellwig wrote: > > Originally-from: Christoph Hellwig > > This should be a > > From: Christoph Hellwig > > so that git picks up authorship information correctly. > > > XXX: might want a bigger name, and possible a better implementation > > that doesn't require two lookups in the radix tree. > > And these need to be looked into. I can take a stab at it, but I need > to get a few other things off my plate first. Yeah. It works well enough for unsharing blocks, if inefficiently. Not sure what "a bigger name" means, though. I tried feeding the function prototype through figlet but gcc didn't like that. ;) --D