From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Eric Biggers <ebiggers@google.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs@vger.kernel.org
Subject: Re: [PATCH] fscrypto: add authorization check for setting encryption policy
Date: Fri, 9 Sep 2016 21:03:35 -0700 [thread overview]
Message-ID: <20160910040335.GA34151@jaegeuk> (raw)
In-Reply-To: <20160910033759.qsvg4loedccqc7if@thunk.org>
On Fri, Sep 09, 2016 at 11:37:59PM -0400, Theodore Ts'o wrote:
> On Thu, Sep 08, 2016 at 10:57:08AM -0700, Eric Biggers wrote:
> > On an ext4 or f2fs filesystem with file encryption supported, a user
> > could set an encryption policy on any empty directory(*) to which they
> > had readonly access. This is obviously problematic, since such a
> > directory might be owned by another user and the new encryption policy
> > would prevent that other user from creating files in their own directory
> > (for example).
> >
> > Fix this by requiring inode_owner_or_capable() permission to set an
> > encryption policy. This means that either the caller must own the file,
> > or the caller must have the capability CAP_FOWNER.
> >
> > (*) Or also on any regular file, for f2fs v4.6 and later and ext4
> > v4.8-rc1 and later; a separate bug fix is coming for that.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > Cc: stable@vger.kernel.org # 4.1+; check fs/{ext4,f2fs}
>
> Thanks, applied. (Jaeguk, I plan to send this to Linus via the
> ext4.git tree as a fix for v4.8)
Sure, no problem.
>
> - Ted
prev parent reply other threads:[~2016-09-10 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 17:57 [PATCH] fscrypto: add authorization check for setting encryption policy Eric Biggers
2016-09-08 18:20 ` Eric Biggers
2016-09-10 3:37 ` Theodore Ts'o
2016-09-10 4:03 ` Jaegeuk Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160910040335.GA34151@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=ebiggers@google.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).