From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com ([192.55.52.120]:34549 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932743AbcIMWyl (ORCPT ); Tue, 13 Sep 2016 18:54:41 -0400 Date: Tue, 13 Sep 2016 16:54:39 -0600 From: Ross Zwisler To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org Subject: Re: [PATCH 04/10] dax: don't pass buffer_head to copy_user_dax Message-ID: <20160913225439.GD26002@linux.intel.com> References: <1473438884-674-1-git-send-email-hch@lst.de> <1473438884-674-5-git-send-email-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1473438884-674-5-git-send-email-hch@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 09, 2016 at 06:34:38PM +0200, Christoph Hellwig wrote: > This way we can use this helper for the iomap based DAX implementation > as well. > > Signed-off-by: Christoph Hellwig Reviewed-by: Ross Zwisler > --- > fs/dax.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 98463bb..84343ce 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -580,14 +580,13 @@ static int dax_load_hole(struct address_space *mapping, void *entry, > return VM_FAULT_LOCKED; > } > > -static int copy_user_bh(struct page *to, struct inode *inode, > - struct buffer_head *bh, unsigned long vaddr) > +static int copy_user_dax(struct block_device *bdev, sector_t sector, size_t size, > + struct page *to, unsigned long vaddr) > { > struct blk_dax_ctl dax = { > - .sector = to_sector(bh, inode), > - .size = bh->b_size, > + .sector = sector, > + .size = size, > }; > - struct block_device *bdev = bh->b_bdev; > void *vto; > > if (dax_map_atomic(bdev, &dax) < 0) > @@ -867,7 +866,8 @@ int dax_fault(struct vm_area_struct *vma, struct vm_fault *vmf, > if (vmf->cow_page) { > struct page *new_page = vmf->cow_page; > if (buffer_written(&bh)) > - error = copy_user_bh(new_page, inode, &bh, vaddr); > + error = copy_user_dax(bh.b_bdev, to_sector(&bh, inode), > + bh.b_size, new_page, vaddr); > else > clear_user_highpage(new_page, vaddr); > if (error) > -- > 2.1.4 > > _______________________________________________ > Linux-nvdimm mailing list > Linux-nvdimm@lists.01.org > https://lists.01.org/mailman/listinfo/linux-nvdimm