From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ipmail07.adl2.internode.on.net ([150.101.137.131]:12358 "EHLO ipmail07.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934051AbcIUWdv (ORCPT ); Wed, 21 Sep 2016 18:33:51 -0400 Date: Thu, 22 Sep 2016 08:33:31 +1000 From: Dave Chinner To: Al Viro Cc: Amir Goldstein , Miklos Szeredi , "linux-unionfs@vger.kernel.org" , Christoph Hellwig , linux-xfs@vger.kernel.org, "Darrick J . Wong" , linux-fsdevel Subject: Re: [PATCH v3 2/4] ovl: use vfs_clone_file_range() for copy up if possible Message-ID: <20160921223331.GE10454@dastard> References: <1473856994-27463-1-git-send-email-amir73il@gmail.com> <1473856994-27463-3-git-send-email-amir73il@gmail.com> <20160921214814.GC10454@dastard> <20160921215724.GV2356@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160921215724.GV2356@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Sep 21, 2016 at 10:57:24PM +0100, Al Viro wrote: > On Thu, Sep 22, 2016 at 07:48:15AM +1000, Dave Chinner wrote: > > > If you get any error other than -EXDEV or -EOPNOTSUPP from a clone > > operation, there's somethign seriously wrong with the metadata of > > the inode or the underlying storage. > > Such as -ENOSPC? Yup, that's a fatal error, too. i.e. if a clone returns ENOSPC because there isn't space for the extra metadata, then the fallback data copy is almost certainly going to fail with ENOSPC when trying to reserve/allocate space for both the extra data copy and the extra metadata.... Cheers, Dave. -- Dave Chinner david@fromorbit.com