From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: remove dirty inode pages in error path
Date: Sat, 24 Sep 2016 10:47:13 -0700 [thread overview]
Message-ID: <20160924174713.GA25123@jaegeuk> (raw)
In-Reply-To: <f51439e8-ea3b-836f-b967-d0e1446e952b@huawei.com>
On Sat, Sep 24, 2016 at 09:02:02AM +0800, Chao Yu wrote:
> On 2016/9/24 5:11, Jaegeuk Kim wrote:
> > When getting EIO while handling orphan inodes, we can get some dirty node
> > pages. Then, f2fs_write_node_pages() called by iput(node_inode) will try
> > to flush node pages. But in this case, we should prevent to do that, since
> > we will try again from the start.
>
> We are protected since we set SBI_POR_DOING flag in sb, so we are safe now?
Safe, but we get an infinite loop to flush node pages.
>
> Thanks,
next prev parent reply other threads:[~2016-09-24 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 21:11 [PATCH] f2fs: remove dirty inode pages in error path Jaegeuk Kim
2016-09-24 1:02 ` Chao Yu
2016-09-24 17:47 ` Jaegeuk Kim [this message]
2016-09-26 1:04 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160924174713.GA25123@jaegeuk \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).