From: Christoph Hellwig <hch@lst.de>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-nvdimm@ml01.01.org
Subject: Re: [PATCH 06/10] dax: provide an iomap based fault handler
Date: Mon, 26 Sep 2016 02:05:16 +0200 [thread overview]
Message-ID: <20160926000516.GA32138@lst.de> (raw)
In-Reply-To: <20160914170759.GA14196@linux.intel.com>
On Wed, Sep 14, 2016 at 11:07:59AM -0600, Ross Zwisler wrote:
> I'll bite - why do you think adding a space before labels is a "fairly
> horrible style"?
It introduces single whitespace indentation in a source base that is
all about tabs and uses whitespaces very sparingly (some people use
it to align function arguments, while others also consistently use tabs).
It's also a bit annoying when touching these error label chains for any
sort of major change.
> Adding them gives a tangible benefit for unified diffs and
> patches because it's much more useful to know that a change is in a given
> function than that it follows a label called "out", which could be defined
> many times in a given file. Again, the example:
Yes, but this is just diff beeing stupid. There is no reason why diff
couldn't handle this properly even without the space, and in fact at
least git diff can be tought easily to do just that.
There are a few threads about this label style going on on lkml in
the last week, and one of them mentions the git diff tweak. Try searching
for "Clarify and complete chapter 7".
next prev parent reply other threads:[~2016-09-26 0:05 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-09 16:34 iomap based DAX path Christoph Hellwig
2016-09-09 16:34 ` [PATCH 01/10] iomap: add IOMAP_F_NEW flag Christoph Hellwig
2016-09-13 22:43 ` Ross Zwisler
2016-09-14 7:08 ` Christoph Hellwig
2016-09-09 16:34 ` [PATCH 02/10] iomap: expose iomap_apply outside iomap.c Christoph Hellwig
2016-09-13 22:48 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 03/10] dax: don't pass buffer_head to dax_insert_mapping Christoph Hellwig
2016-09-13 22:53 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 04/10] dax: don't pass buffer_head to copy_user_dax Christoph Hellwig
2016-09-13 22:54 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 05/10] dax: provide an iomap based dax read/write path Christoph Hellwig
2016-09-13 23:00 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 06/10] dax: provide an iomap based fault handler Christoph Hellwig
2016-09-09 22:55 ` Dave Chinner
2016-09-10 7:36 ` Christoph Hellwig
2016-09-13 15:51 ` Ross Zwisler
2016-09-14 7:06 ` Christoph Hellwig
2016-09-14 9:53 ` Christoph Hellwig
2016-09-23 21:02 ` Ross Zwisler
2016-09-26 0:08 ` Christoph Hellwig
2016-09-26 14:28 ` Jan Kara
2016-09-10 1:38 ` Elliott, Robert (Persistent Memory)
2016-09-13 23:10 ` Ross Zwisler
2016-09-14 7:19 ` Christoph Hellwig
2016-09-14 17:07 ` Ross Zwisler
2016-09-15 5:12 ` Christoph Hellwig
2016-09-15 5:30 ` Darrick J. Wong
2016-09-26 0:05 ` Christoph Hellwig [this message]
2016-09-09 16:34 ` [PATCH 07/10] xfs: fix locking for DAX writes Christoph Hellwig
2016-09-09 16:34 ` [PATCH 08/10] xfs: take the ilock shared if possible in xfs_file_iomap_begin Christoph Hellwig
2016-09-09 16:34 ` [PATCH 09/10] xfs: refactor xfs_setfilesize Christoph Hellwig
2016-09-13 23:12 ` Ross Zwisler
2016-09-09 16:34 ` [PATCH 10/10] xfs: use iomap to implement DAX Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160926000516.GA32138@lst.de \
--to=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=linux-xfs@vger.kernel.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).