From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@ml01.01.org,
Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>
Subject: Re: [PATCH 0/6] dax: Page invalidation fixes
Date: Fri, 30 Sep 2016 01:59:05 -0700 [thread overview]
Message-ID: <20160930085905.GF22381@infradead.org> (raw)
In-Reply-To: <1474994615-29553-1-git-send-email-jack@suse.cz>
On Tue, Sep 27, 2016 at 06:43:29PM +0200, Jan Kara wrote:
> Hello,
>
> these patches fix races when invalidating hole pages in DAX mappings. See
> changelogs for details. The series is based on my patches to write-protect
> DAX PTEs because we really need to closely track dirtiness (and cleanness!)
> of radix tree entries in DAX mappings in order to avoid discarding valid
> dirty bits leading to missed cache flushes on fsync(2).
Except for the VM magic I don't feel qualified to review this looks fine
to me. But don't we need to switch ext4 away from going through the DIO
path first before the limited invalidation is effective there?
Otherwise we'll still get the full range invalidation from
generic_file_direct_write?
next prev parent reply other threads:[~2016-09-30 8:59 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:43 [PATCH 0/6] dax: Page invalidation fixes Jan Kara
2016-09-27 16:43 ` [PATCH 1/6] dax: Do not warn about BH_New buffers Jan Kara
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 2/6] ext2: Return BH_New buffers for zeroed blocks Jan Kara
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 3/6] ext4: Remove clearing of BH_New bit " Jan Kara
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks() Jan Kara
2016-09-27 17:01 ` Christoph Hellwig
2016-09-27 17:17 ` Jan Kara
2016-09-28 0:22 ` Dave Chinner
2016-10-03 14:44 ` Jan Kara
2016-09-28 2:13 ` Christoph Hellwig
2016-10-03 14:42 ` Jan Kara
2016-10-03 16:39 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 5/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-09-28 0:18 ` Dave Chinner
2016-10-03 14:52 ` Jan Kara
2016-09-30 8:57 ` Christoph Hellwig
2016-10-03 12:56 ` Jan Kara
2016-09-27 16:43 ` [PATCH 6/6] dax: Avoid page invalidation races and unnecessary radix tree traversals Jan Kara
2016-09-28 0:20 ` Dave Chinner
2016-10-03 14:58 ` Jan Kara
2016-10-03 23:40 ` Dave Chinner
2016-09-30 8:55 ` Christoph Hellwig
2016-10-03 15:02 ` Jan Kara
2016-09-30 8:59 ` Christoph Hellwig [this message]
2016-10-03 13:01 ` [PATCH 0/6] dax: Page invalidation fixes Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160930085905.GF22381@infradead.org \
--to=hch@infradead.org \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).