From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:38896 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932539AbcI3ROh (ORCPT ); Fri, 30 Sep 2016 13:14:37 -0400 Date: Fri, 30 Sep 2016 19:14:34 +0200 From: Oleg Nesterov To: Jan Kara Cc: Al Viro , Dave Chinner , Nikolay Borisov , "Paul E. McKenney" , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/2] fs/super.c: don't fool lockdep in freeze_super() and thaw_super() paths Message-ID: <20160930171434.GA2373@redhat.com> References: <20160926160724.GA6739@redhat.com> <20160926160806.GB6748@redhat.com> <20160926161856.GB32458@quack2.suse.cz> <20160926165525.GA9338@redhat.com> <20160927065135.GA1139@quack2.suse.cz> <20160927172901.GA11879@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160927172901.GA11879@redhat.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 09/27, Oleg Nesterov wrote: > > On 09/27, Jan Kara wrote: > > > > You can run either: > > > > ./check -g freeze > > passed all 6 tests. > > > to check just the freezing tests or > > > > ./check > > > > to run all sensible tests which is what I'd do (but it will take couple of > > hours to pass). If that passes, chances are good there are no easy false > > positives. > > It seems that generic/001 just hangs on my laptop. With or without this change. > Or perhaps I didn't wait enough... /usr/bin/awk spins in user-mode forever, according to strace it doesn't do any syscalls. I didn't even try to investigate. > Or perhaps something is wrong with my very > limited testing environment. I'll reserve a testing machine tomorrow. Jan, I gave up. Whatever I did xfstests-dev/check reports a lot of failures, kernel bugs, and finally either crashes the kernel or hangs. With or without this change, and I didn't notice any warning from lockdep. So I hope we can apply this patch. At least 1/2 which fixes a bug. Oleg.