From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail.kernel.org ([198.145.29.136]:48068 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752255AbcJAAzp (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 30 Sep 2016 20:55:45 -0400
Date: Fri, 30 Sep 2016 17:54:49 -0700
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: use crc and cp version to
 determine roll-forward recovery
Message-ID: <20161001005449.GA63648@jaegeuk>
References: <20160920025504.72524-1-jaegeuk@kernel.org>
 <20160930171005.GC46477@jaegeuk>
 <5758dbdd-610e-64cf-3cef-44794e5b32b4@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5758dbdd-610e-64cf-3cef-44794e5b32b4@kernel.org>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sat, Oct 01, 2016 at 08:26:20AM +0800, Chao Yu wrote:
> On 2016/10/1 1:10, Jaegeuk Kim wrote:
> > @@ -1089,6 +1079,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc)
> >  	if (is_sbi_flag_set(sbi, SBI_NEED_FSCK))
> >  		set_ckpt_flags(ckpt, CP_FSCK_FLAG);
> >  
> > +	/* set this flag to activate crc|cp_ver for recovery */
> > +	set_ckpt_flags(ckpt, CP_CRC_RECOVERY_FLAG);
> 
> Should let new introduced spinlock cover the flag updating in ("f2fs: introduce
> cp_lock to protect updating of ckpt_flags").

Fixed.

http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=aaec2b1d18792a5f27b69ff37f34f43f89f5aa3b

Thank you. :)

> 
> Thanks,