From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:40160 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbcJCOwM (ORCPT ); Mon, 3 Oct 2016 10:52:12 -0400 Date: Mon, 3 Oct 2016 16:52:09 +0200 From: Jan Kara To: Dave Chinner Cc: Jan Kara , linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, Dan Williams , Ross Zwisler Subject: Re: [PATCH 5/6] mm: Invalidate DAX radix tree entries only if appropriate Message-ID: <20161003145209.GC14183@quack2.suse.cz> References: <1474994615-29553-1-git-send-email-jack@suse.cz> <1474994615-29553-6-git-send-email-jack@suse.cz> <20160928001839.GE9806@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160928001839.GE9806@dastard> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed 28-09-16 10:18:40, Dave Chinner wrote: > On Tue, Sep 27, 2016 at 06:43:34PM +0200, Jan Kara wrote: > > +/* > > + * Invalidate exceptional DAX entry if it is clean. > > + */ > > +int dax_invalidate_mapping_entry2(struct address_space *mapping, pgoff_t index) > > +{ > > + return __dax_invalidate_mapping_entry(mapping, index, false); > > } > > dax_try_invalidate_mapping_entry() Or maybe dax_invalidate_clean_mapping_entry()? I was originally trying to keep consistency with how functions in mm/truncate.c are traditionally called but even there it's not quite consistent so better have a more descriptive name. Honza -- Jan Kara SUSE Labs, CR