linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered)
@ 2016-09-26 16:07 Oleg Nesterov
  2016-09-26 16:07 ` [PATCH 1/2] fs/super.c: fix race between freeze_super() and thaw_super() Oleg Nesterov
                   ` (2 more replies)
  0 siblings, 3 replies; 30+ messages in thread
From: Oleg Nesterov @ 2016-09-26 16:07 UTC (permalink / raw)
  To: Al Viro
  Cc: Dave Chinner, Jan Kara, Nikolay Borisov, Paul E. McKenney,
	linux-fsdevel, linux-kernel

Hello,

The patches do not depend on each other.

1/2 is the trivial fix, imo -stable material. The bug is very old it seems,
but today this race (leading to unbalanced unlock)  manifests itself via
mysterious BUG_ON's in rcu/sync.c.

2/2 is old, I forgot to send it before. It was already reviewed by Dave and Jan,
but the generic/068 test from xfstests triggered the warning. This was fixed by
dbad7c993053 "xfs: stop holding ILOCK over filldir callbacks" so we can hopefully
kill the early-lockdep-release kludge.

Oleg.

 fs/super.c | 43 ++++++++++++++++++++++++++++---------------
 1 file changed, 28 insertions(+), 15 deletions(-)


^ permalink raw reply	[flat|nested] 30+ messages in thread

end of thread, other threads:[~2016-10-13 17:10 UTC | newest]

Thread overview: 30+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 16:07 [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered) Oleg Nesterov
2016-09-26 16:07 ` [PATCH 1/2] fs/super.c: fix race between freeze_super() and thaw_super() Oleg Nesterov
2016-09-26 16:11   ` Jan Kara
2016-09-26 16:08 ` [PATCH 2/2] fs/super.c: don't fool lockdep in freeze_super() and thaw_super() paths Oleg Nesterov
2016-09-26 16:18   ` Jan Kara
2016-09-26 16:55     ` [PATCH V2 " Oleg Nesterov
2016-09-27  6:51       ` Jan Kara
2016-09-27  7:14         ` Dave Chinner
2016-09-27 17:29         ` Oleg Nesterov
2016-09-30 17:14           ` Oleg Nesterov
2016-10-02 21:42             ` Dave Chinner
2016-10-03 16:44               ` Oleg Nesterov
2016-10-04 11:43                 ` Oleg Nesterov
2016-10-04 11:48                   ` Michal Hocko
2016-10-06 13:44                     ` Johannes Weiner
2016-10-07 16:52                       ` Oleg Nesterov
2016-10-04 16:58                   ` Oleg Nesterov
2016-10-04 20:03                     ` Dave Chinner
2016-10-05 16:33                       ` Oleg Nesterov
2016-10-04 19:44                   ` Dave Chinner
2016-10-05 16:44                     ` Oleg Nesterov
2016-10-06  7:27                       ` Jan Kara
2016-10-06 17:17                       ` Oleg Nesterov
2016-10-06 21:59                         ` Dave Chinner
2016-10-07 17:15                           ` Oleg Nesterov
2016-10-07 22:52                             ` Dave Chinner
2016-10-09 16:14                               ` Oleg Nesterov
2016-10-10  1:02                                 ` Dave Chinner
2016-10-13 16:58                                   ` Oleg Nesterov
2016-10-13 17:10 ` [PATCH 0/2] (Was: BUG_ON in rcu_sync_func triggered) Oleg Nesterov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).