From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from imap.thunk.org ([74.207.234.97]:56436 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934235AbcJMEoF (ORCPT ); Thu, 13 Oct 2016 00:44:05 -0400 Date: Wed, 12 Oct 2016 23:39:53 -0400 From: Theodore Ts'o To: Eric Biggers Cc: Richard Weinberger , linux-fsdevel , linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org Subject: Re: [PATCH] fscrypto: make XTS tweak initialization endian-independent Message-ID: <20161013033953.sgohuvud5krlupf3@thunk.org> References: <1475258329-146528-1-git-send-email-ebiggers@google.com> <20161003180340.GA54410@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161003180340.GA54410@google.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Sep 30, 2016 at 7:58 PM, Eric Biggers wrote: > The XTS tweak (or IV) was initialized differently on little endian and > big endian systems. Because the ciphertext depends on the XTS tweak, it > was not possible to use an encrypted filesystem created by a little > endian system on a big endian system and vice versa, even if they shared > the same PAGE_SIZE. Fix this by always using little endian. > > This will break hypothetical big endian users of ext4 or f2fs > encryption. However, all users we are aware of are little endian, and > it's believed that "real" big endian users are unlikely to exist yet. > So this might as well be fixed now before it's too late. > > Signed-off-by: Eric Biggers Thanks, applied. - Ted