From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:46332 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbcJMUJ7 (ORCPT ); Thu, 13 Oct 2016 16:09:59 -0400 Date: Thu, 13 Oct 2016 13:09:04 -0700 From: Christoph Hellwig To: Vineeth Remanan Pillai Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, kamatam@amazon.com, aliguori@amazon.com Subject: Re: [PATCH] namei: revert old behaviour for filename_lookup with LOOKUP_PARENT flag Message-ID: <20161013200904.GA23139@infradead.org> References: <1476388731-24053-1-git-send-email-vineethp@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1476388731-24053-1-git-send-email-vineethp@amazon.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Oct 13, 2016 at 07:58:51PM +0000, Vineeth Remanan Pillai wrote: > filename_lookup used to return success for non-existing file when called > with LOOKUP_PARENT flag. This behaviour was changed with > commit 8bcb77fabd7c ("namei: split off filename_lookupat() > with LOOKUP_PARENT") > > The above patch split parent lookup functionality to a different function > filename_parentat and changed all calls to filename_lookup(LOOKUP_PARENT) > to the new function filename_parentat. But functions like kern_path which > passed the flags directly to filename_lookup regressed due to this. > > This patch aims to fix the regressed behaviour by calling > filename_parentat from filename_lookup if the flags contain LOOKUP_PARENT. What callers shows te problems? That's probaby were the fix need to got in, and even if not that's still part of a good bug report.