From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-pf0-f175.google.com ([209.85.192.175]:33262 "EHLO
        mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1755361AbcJNSMB (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 14 Oct 2016 14:12:01 -0400
Received: by mail-pf0-f175.google.com with SMTP id 128so53313596pfz.0
        for <linux-fsdevel@vger.kernel.org>; Fri, 14 Oct 2016 11:12:00 -0700 (PDT)
Date: Fri, 14 Oct 2016 11:11:52 -0700
From: Eric Biggers <ebiggers@google.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, tytso@mit.edu,
        jaegeuk@kernel.org
Subject: Re: [PATCH] fscrypto: lock inode while setting encryption policy
Message-ID: <20161014181152.GA65380@google.com>
References: <1475087688-4048-1-git-send-email-ebiggers@google.com>
 <ea8b7140-f04e-380d-b5ae-263f029c0624@nod.at>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ea8b7140-f04e-380d-b5ae-263f029c0624@nod.at>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, Sep 29, 2016 at 07:20:20PM +0200, Richard Weinberger wrote:
> On 28.09.2016 20:34, Eric Biggers wrote:
> > i_rwsem needs to be acquired while setting an encryption policy so that
> > concurrent calls to FS_IOC_SET_ENCRYPTION_POLICY are correctly
> > serialized (especially the ->get_context() + ->set_context() pair), and
> > so that new files cannot be created in the directory during or after the
> > ->empty_dir() check.
> > 
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> 
> Reviewed-by: Richard Weinberger <richard@nod.at>
> 
> Thanks,
> //richard

Thanks.  Does anyone else have comments on this patch?  It hasn't been applied
yet.

Eric