From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.9]:37740 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753745AbcJUMFo (ORCPT ); Fri, 21 Oct 2016 08:05:44 -0400 Date: Fri, 21 Oct 2016 05:05:42 -0700 From: Christoph Hellwig To: Jan Kara Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH 1/4] fs: Provide function to unmap metadata for a range of blocks Message-ID: <20161021120542.GA20475@infradead.org> References: <1477050941-29682-1-git-send-email-jack@suse.cz> <1477050941-29682-2-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1477050941-29682-2-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > + * Functionally, this is like unmap_underlying_metadata() for a range of > + * blocks. It is implemented to be more efficient for larger ranges of blocks > + * though. > + */ > +void unmap_underlying_metadata_ext(struct block_device *bdev, sector_t block, > + sector_t len) Please explain what it does and why you'd call it. And while we're naming I think the 'metadata' part is highly confusing. What it does is to clear buffers from the block device mapping, nothing about metadata really. So how about unmap_buffers_range or similar?