From: Eric Biggers <ebiggers@google.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
jaegeuk@kernel.org, tytso@mit.edu
Subject: Re: [PATCH 1/2] fscrypto: Fix log string in do_crypto()
Date: Fri, 21 Oct 2016 13:02:00 -0700 [thread overview]
Message-ID: <20161021200200.GA137744@google.com> (raw)
In-Reply-To: <1476824089-6841-2-git-send-email-richard@nod.at>
On Tue, Oct 18, 2016 at 10:54:48PM +0200, Richard Weinberger wrote:
> The operations supports both encryption and decryption.
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> fs/crypto/crypto.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/crypto/crypto.c b/fs/crypto/crypto.c
> index 61057b7dbddb..1637a0450b9f 100644
> --- a/fs/crypto/crypto.c
> +++ b/fs/crypto/crypto.c
> @@ -194,8 +194,9 @@ static int do_page_crypto(struct inode *inode,
> skcipher_request_free(req);
> if (res) {
> printk_ratelimited(KERN_ERR
> - "%s: crypto_skcipher_encrypt() returned %d\n",
> - __func__, res);
> + "%s: crypto_skcipher_%scrypt() returned %d, flags %#x\n",
> + __func__, rw == FS_DECRYPT ? "de" : "en", res,
> + crypto_skcipher_get_flags(tfm));
> return res;
> }
> return 0;
> --
> 2.7.3
>
Looks fine.
Reviewed-by: Eric Biggers <ebiggers@google.com>
next prev parent reply other threads:[~2016-10-21 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 20:54 fscrypto: Two trivial patches Richard Weinberger
2016-10-18 20:54 ` [PATCH 1/2] fscrypto: Fix log string in do_crypto() Richard Weinberger
2016-10-21 20:02 ` Eric Biggers [this message]
2016-10-18 20:54 ` [PATCH 2/2] fscrypto: Fix fscrypt_decrypt_page() doc string Richard Weinberger
2016-10-21 20:02 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021200200.GA137744@google.com \
--to=ebiggers@google.com \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).