From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Vrabel <david.vrabel@citrix.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xenproject.org,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>
Subject: Re: [PATCH v4 0/3] libfs,xenfs: replace /proc/xen/xenbus with a symlink
Date: Fri, 28 Oct 2016 17:22:27 +0100 [thread overview]
Message-ID: <20161028162227.GN19539@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1477669959-9486-1-git-send-email-david.vrabel@citrix.com>
On Fri, Oct 28, 2016 at 04:52:36PM +0100, David Vrabel wrote:
> Using /proc/xen/xenbus can cause deadlocks on the atomic file position
> mutex since this file should behave like a character device and not a
> regular file. This is easiest to achive by making it a symlink to the
> existing /dev/xen/xenbus device.
What. The. Hell? What's wrong with simply adding
file->f_mode &= ~FMODE_ATOMIC_POS; /* cdev-style semantics */
in the ->open() of those files, rather than going through all those
convolutions?
prev parent reply other threads:[~2016-10-28 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 15:52 [PATCH v4 0/3] libfs,xenfs: replace /proc/xen/xenbus with a symlink David Vrabel
2016-10-28 15:52 ` [PATCHv4 1/3] libfs: allow simple_fill_super() to add symlinks David Vrabel
2016-10-28 15:52 ` [PATCHv4 2/3] xenfs: replace xenbus and privcmd with symlinks David Vrabel
2016-10-28 15:52 ` [PATCHv4 3/3] xenfs: Use proc_create_mount_point() to create /proc/xen David Vrabel
2016-10-28 16:22 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028162227.GN19539@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jgross@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).