From: Christoph Hellwig <hch@lst.de>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Al Viro <viro@zeniv.linux.org.uk>, Jan Kara <jack@suse.cz>,
Dmitry Monakhov <dmonakhov@openvz.org>,
Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-aio@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file operation
Date: Tue, 1 Nov 2016 15:25:34 +0100 [thread overview]
Message-ID: <20161101142534.GC17142@lst.de> (raw)
In-Reply-To: <20161031202521.GN22126@dastard>
On Tue, Nov 01, 2016 at 07:25:21AM +1100, Dave Chinner wrote:
> That sounds like a problem with your fix - it should work
> regardless of whether a valid/implemented AIO function is called
> or not, right? There's no difference between an invalid command,
> IOCB_CMD_FSYNC where ->aio_fsync() is null, or some supported
> command that immediately returns -EIO, the end result should
> be the same...
We would need the same increased file refcount if aio_fsync actually
was implemented using -EIOCBQUEUED returns. We wouldn't nessecarily need
it without that.
> > I'm not going to complain about a proper implementation, but right now
> > we don't have any, and I'm not even sure the method signature is
> > all that suitable. E.g. for the in-kernel users we'd really want a
> > ranged fsync like the normal fsync anyway.
>
> You mean like this version I posted a year ago:
>
> https://lkml.org/lkml/2015/10/29/517
I'd love to see that one in - but it doesn't use the aio_fsync method
either..
next prev parent reply other threads:[~2016-11-01 14:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 16:42 aio fixes for use after free and freeze protection Christoph Hellwig
2016-10-30 16:42 ` [PATCH 1/4] aio: hold an extra file reference over AIO read/write operations Christoph Hellwig
2016-10-30 16:42 ` [PATCH 2/4] fs: remove the never implemented aio_fsync file operation Christoph Hellwig
2016-10-30 23:23 ` Dave Chinner
2016-10-31 13:07 ` Christoph Hellwig
2016-10-31 20:25 ` Dave Chinner
2016-11-01 1:30 ` Linus Torvalds
2016-11-01 14:30 ` Christoph Hellwig
2016-11-01 15:07 ` Linus Torvalds
2016-11-01 14:25 ` Christoph Hellwig [this message]
2016-10-30 16:42 ` [PATCH 3/4] fs: remove aio_run_iocb Christoph Hellwig
2016-10-30 16:42 ` [PATCH 4/4] aio: fix freeze protection of aio writes Christoph Hellwig
2016-10-30 16:58 ` aio fixes for use after free and freeze protection Al Viro
2016-10-30 17:01 ` Christoph Hellwig
2016-11-09 2:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101142534.GC17142@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).