From: Christoph Hellwig <hch@lst.de>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Dave Chinner <david@fromorbit.com>,
Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Jan Kara <jack@suse.cz>, Dmitry Monakhov <dmonakhov@openvz.org>,
Jeff Moyer <jmoyer@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-aio@kvack.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] fs: remove the never implemented aio_fsync file operation
Date: Tue, 1 Nov 2016 15:30:08 +0100 [thread overview]
Message-ID: <20161101143008.GD17142@lst.de> (raw)
In-Reply-To: <CA+55aFzydDRVqbgTgrEuPE4QuO6PE2eiR_3ULL-u4H0_10Y0Ew@mail.gmail.com>
On Mon, Oct 31, 2016 at 06:30:11PM -0700, Linus Torvalds wrote:
> I still suspect that if we want to do this, we should strive to expose
> all the other syncing flags from sync_file_range() too.
sync_file_range is entirely different from fsync -
sync_file_range allows you detailed control of data writeback, but it
does not allow to commit metadata at all, i.e. it's not a data integrity
operation.
> Yeah, that's more of a "keep writes streaming" interface than a
> fsync() like interface, but I think the two really do fit together.
> It's kind of sad how we have this very fragmented interface to
> writeback, where some operations take that "data vs metadata", some
> operations take a range of bytes, and some operations take that "start
> writeback vs wait for it", but nothing does all of the above. They are
> really just different faces of the same writeback coin.
sync_file_range at the moment actually doesn't involve the fs, which
has it's own set of problems. So yes, maybe we need a full blown
sync method unifying fsync, sync_file_range and which enables ranged
data integrity fsync and asynchronous operations of all this.
But to go back to Dave's argument - none of that can archived with that
aio_fsync method added more than 10 years ago and never implemented.
next prev parent reply other threads:[~2016-11-01 14:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 16:42 aio fixes for use after free and freeze protection Christoph Hellwig
2016-10-30 16:42 ` [PATCH 1/4] aio: hold an extra file reference over AIO read/write operations Christoph Hellwig
2016-10-30 16:42 ` [PATCH 2/4] fs: remove the never implemented aio_fsync file operation Christoph Hellwig
2016-10-30 23:23 ` Dave Chinner
2016-10-31 13:07 ` Christoph Hellwig
2016-10-31 20:25 ` Dave Chinner
2016-11-01 1:30 ` Linus Torvalds
2016-11-01 14:30 ` Christoph Hellwig [this message]
2016-11-01 15:07 ` Linus Torvalds
2016-11-01 14:25 ` Christoph Hellwig
2016-10-30 16:42 ` [PATCH 3/4] fs: remove aio_run_iocb Christoph Hellwig
2016-10-30 16:42 ` [PATCH 4/4] aio: fix freeze protection of aio writes Christoph Hellwig
2016-10-30 16:58 ` aio fixes for use after free and freeze protection Al Viro
2016-10-30 17:01 ` Christoph Hellwig
2016-11-09 2:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101143008.GD17142@lst.de \
--to=hch@lst.de \
--cc=david@fromorbit.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-aio@kvack.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).