From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 2 Nov 2016 12:58:48 +0300 From: "Kirill A. Shutemov" To: Jan Kara Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, Andrew Morton , Ross Zwisler Subject: Re: [PATCH 01/21] mm: Join struct fault_env and vm_fault Message-ID: <20161102095848.GB20724@node.shutemov.name> References: <1478039794-20253-1-git-send-email-jack@suse.cz> <1478039794-20253-3-git-send-email-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478039794-20253-3-git-send-email-jack@suse.cz> Sender: owner-linux-mm@kvack.org List-ID: On Tue, Nov 01, 2016 at 11:36:08PM +0100, Jan Kara wrote: > Currently we have two different structures for passing fault information > around - struct vm_fault and struct fault_env. DAX will need more > information in struct vm_fault to handle its faults so the content of > that structure would become event closer to fault_env. Furthermore it > would need to generate struct fault_env to be able to call some of the > generic functions. So at this point I don't think there's much use in > keeping these two structures separate. Just embed into struct vm_fault > all that is needed to use it for both purposes. What about just reference fault_env from vm_fault? We don't always need vm_fault where we nee fault_env. It may save space on stack for some codepaths. -- Kirill A. Shutemov -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org