From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:44086 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbcKDEUJ (ORCPT ); Fri, 4 Nov 2016 00:20:09 -0400 Date: Fri, 4 Nov 2016 05:20:03 +0100 From: Jan Kara To: Ross Zwisler Cc: Jan Kara , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, Dave Chinner , Ted Tso , linux-nvdimm@lists.01.org Subject: Re: [PATCH 01/11] ext4: Factor out checks from ext4_file_write_iter() Message-ID: <20161104042003.GN24234@quack2.suse.cz> References: <1478034381-19037-1-git-send-email-jack@suse.cz> <1478034381-19037-2-git-send-email-jack@suse.cz> <20161103210440.GA27351@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161103210440.GA27351@linux.intel.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu 03-11-16 15:04:40, Ross Zwisler wrote: > On Tue, Nov 01, 2016 at 10:06:11PM +0100, Jan Kara wrote: > > + /* > > + * 'err==len' means that all of blocks has been preallocated no matter > > + * they are initialized or not. For excluding unwritten extents, we > > + * need to check m_flags. > > Does it make sense to clean up this comment, since you're moving it anyway? > > i.e.: > > 'err==len' means that all of the blocks have been preallocated, regardless > of whether they have been initialized or not. To exclude unwritten extents > we need to check m_flags. OK, done. Thanks! Honza -- Jan Kara SUSE Labs, CR