From: Jens Axboe <axboe@kernel.dk>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
ocfs2-devel@oss.oracle.com, Evgeniy Dushistov <dushistov@mail.ru>,
linux-ntfs-dev@lists.sourceforge.net
Subject: Re: [PATCH 0/6 v2] fs: Provide function to unmap metadata for a range of blocks
Date: Fri, 4 Nov 2016 14:32:41 -0600 [thread overview]
Message-ID: <20161104203241.GA11764@kernel.dk> (raw)
In-Reply-To: <1478279296-6575-1-git-send-email-jack@suse.cz>
On Fri, Nov 04 2016, Jan Kara wrote:
> Hello,
>
> I've noticed that in several places we need to unmap metadata in buffer cache
> for a range of blocks and we do it by iterating over all blocks in given range.
> Let's provide a helper function for that and implement it in a way more
> efficient for larger ranges of blocks. Also cleanup other uses of
> unmap_unerlying_metadata(). The patches passed xfstests for ext2 and ext4.
>
> Jens, can you merge these patches if they look fine to you?
Looks clean to me. There's a small typo ("used to used") in the comment
for patch #1, but I'll just correct that manually before applying.
--
Jens Axboe
prev parent reply other threads:[~2016-11-04 20:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 17:08 [PATCH 0/6 v2] fs: Provide function to unmap metadata for a range of blocks Jan Kara
2016-11-04 17:08 ` [PATCH 1/6] " Jan Kara
2016-11-04 17:08 ` [PATCH 2/6] direct-io: Use clean_bdev_aliases() instead of handmade iteration Jan Kara
2016-11-04 17:08 ` [PATCH 3/6] ext4: Use clean_bdev_aliases() instead of iteration Jan Kara
2016-11-07 2:40 ` [lkp] [ext4] adad5aa544: fio.write_bw_MBps +4074.4% improvement kernel test robot
2016-11-04 17:08 ` [PATCH 4/6] ext2: Use clean_bdev_aliases() instead of iteration Jan Kara
2016-11-04 17:08 ` [PATCH 5/6] fs: Add helper to clean bdev aliases under a bh and use it Jan Kara
2016-11-04 17:08 ` [PATCH 6/6] fs: Remove unmap_underlying_metadata Jan Kara
2016-11-04 20:32 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104203241.GA11764@kernel.dk \
--to=axboe@kernel.dk \
--cc=dushistov@mail.ru \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).