From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from zeniv.linux.org.uk ([195.92.253.2]:44652 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756140AbcKJXCY (ORCPT ); Thu, 10 Nov 2016 18:02:24 -0500 Date: Thu, 10 Nov 2016 23:02:21 +0000 From: Al Viro To: Amir Goldstein Cc: Miklos Szeredi , Konstantin Khlebnikov , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC][PATH 4/4] ovl: relax lock_rename when moving files between work and upper dir Message-ID: <20161110230221.GL19539@ZenIV.linux.org.uk> References: <1478817883-27662-1-git-send-email-amir73il@gmail.com> <1478817883-27662-5-git-send-email-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1478817883-27662-5-git-send-email-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Nov 11, 2016 at 12:44:43AM +0200, Amir Goldstein wrote: > If work dir and upper dir have a common parent, then it > is safe to move files between them without taking the super block > s_vfs_rename_mutex. > > Since both upper dir and work dir (as well as $workdir/work) > are delete locked on overlay mount, they cannot be moved. Do explain. What do you mean, "delete locked" and why exactly can't they be moved?