From: Al Viro <viro@ZenIV.linux.org.uk>
To: Fabian Frederick <fabf@skynet.be>
Cc: tytso@mit.edu, Jan Kara <jack@suse.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 linux-next] ext4: add compatibility flag check
Date: Thu, 24 Nov 2016 20:39:00 +0000 [thread overview]
Message-ID: <20161124203900.GS1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1480016861-24432-1-git-send-email-fabf@skynet.be>
On Thu, Nov 24, 2016 at 08:47:41PM +0100, Fabian Frederick wrote:
> data=journal mount option should disable O_DIRECT access
> (See Documentation/filesystems/ext4.txt) but open operations
> using O_CREAT|O_RDWR|O_DIRECT|O_SYNC have no warning in return and file is being
> created. This patch adds vfs super_operations compatibility flag function
> returning -EPERM in such a case.
Why not simply check it in ->open()? Occam's Razor and all such...
next prev parent reply other threads:[~2016-11-24 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-24 19:47 [PATCH 1/1 linux-next] ext4: add compatibility flag check Fabian Frederick
2016-11-24 20:39 ` Al Viro [this message]
2016-11-24 21:43 ` Fabian Frederick
2016-11-25 5:26 ` Theodore Ts'o
2016-11-25 6:14 ` Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124203900.GS1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=fabf@skynet.be \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).