From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f41.google.com ([74.125.83.41]:33369 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753231AbcK0EVE (ORCPT ); Sat, 26 Nov 2016 23:21:04 -0500 Received: by mail-pg0-f41.google.com with SMTP id 3so43787846pgd.0 for ; Sat, 26 Nov 2016 20:21:04 -0800 (PST) Date: Sat, 26 Nov 2016 20:20:48 -0800 From: Eric Biggers To: Theodore Ts'o Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, jaegeuk@kernel.org Subject: Re: [PATCH] fscrypto: move ioctl processing more fully into common code Message-ID: <20161127042048.GA34163@google.com> References: <1476723246-47420-1-git-send-email-ebiggers@google.com> <20161127000901.wuyl6t6wp6qhmkrs@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161127000901.wuyl6t6wp6qhmkrs@thunk.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sat, Nov 26, 2016 at 07:09:01PM -0500, Theodore Ts'o wrote: > On Mon, Oct 17, 2016 at 09:54:06AM -0700, Eric Biggers wrote: > > In addition, make the common functions do the copies to and from > > userspace rather than duplicating this code within each filesystem, and > > memset the policy to 0 to make it clear there is no stack leak. > > I don't see any point of doing this, given that we initialize all > parts of the fscrypt_policy structure; and since this structure is > part of UAPI, we can't change it without breaking userspace. > > I'll apply this with the memset (and the above comment in the commit > description) removed. > > - Ted I guess I'm okay with that, since struct fscrypt_policy won't have any padding bytes because its members are all bytes. Plus it's marked __packed, though I think that was a mistake given that the struct isn't stored on disk directly. Eric