From: Christoph Hellwig <hch@lst.de>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Al Viro <viro@zeniv.linux.org.uk>,
Anna.Schumaker@netapp.com,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] fs: try to clone files first in vfs_copy_file_range
Date: Tue, 29 Nov 2016 13:08:55 +0100 [thread overview]
Message-ID: <20161129120855.GA17073@lst.de> (raw)
In-Reply-To: <CAOQ4uxh8DgL6KyhY+=yintpKkOPh5gpn5AGaUUdGvO+dx5rMRw@mail.gmail.com>
On Tue, Nov 29, 2016 at 12:28:01PM +0200, Amir Goldstein wrote:
> On Tue, Nov 29, 2016 at 10:55 AM, Christoph Hellwig <hch@lst.de> wrote:
> > [fullquote removed, please get your email etiquette right or I'll stop
> > responding]
> >
>
> Sorry. I though the practice was to keep original patch in tact for review.
The practice is to quote what's relevant. You generally have a lot of
leeway to decide how much exactly you think fits, but a fullquote only
ever makes sense when forwarding the mail to someone not previously
involved with the thread.
> To be fair, Clone is a fast metadata operation on xfs/btrfs/ocfs2.
> I don't think we can know for sure how a future file systems will choose to
> implement clone, nor can we tell for sure how any version of remote Windows CIFS
> server will implement it.
If it's not a fast and atomic metadata operation it must not implement
clone_file_range, but should implement copy_file_range instead.
prev parent reply other threads:[~2016-11-29 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-25 8:40 make copy_file_range do the right thing Christoph Hellwig
2016-11-25 8:40 ` [PATCH] fs: try to clone files first in vfs_copy_file_range Christoph Hellwig
2016-11-29 5:15 ` Amir Goldstein
2016-11-29 8:55 ` Christoph Hellwig
2016-11-29 10:28 ` Amir Goldstein
2016-11-29 12:08 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129120855.GA17073@lst.de \
--to=hch@lst.de \
--cc=Anna.Schumaker@netapp.com \
--cc=amir73il@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).