Re: [PATCH 2/6] mm: Invalidate DAX radix tree entries only if appropriate

[Johannes Weiner <hannes@cmpxchg.org>]

On Wed, Nov 30, 2016 at 09:08:41AM +0100, Jan Kara wrote:
> > The naming situation with truncate, invalidate, invalidate2 worries me
> > a bit. They aren't great names to begin with, but now DAX uses yet
> > another terminology for what state prevents a page from being dropped.
> > Can we switch to truncate, invalidate, and invalidate_sync throughout
> > truncate.c and then have DAX follow that naming too? Or maybe you can
> > think of better names. But neither invalidate2 and invalidate_clean
> > don't seem to capture it quite right ;)
> 
> Yeah, the naming is confusing. I like the invalidate_sync proposal however
> renaming invalidate_inode_pages2() to invalidate_inode_pages_sync() is a
> larger undertaking - grep shows 51 places need to be changed. So I don't
> want to do it in this patch set. I can call the function
> dax_invalidate_mapping_entry_sync() if it makes you happier and do the rest
> later... OK?

Yep, that sounds reasonable on both counts.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>