From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-unionfs@vger.kernel.org
Subject: Re: [GIT PULL] readlink cleanup
Date: Sun, 11 Dec 2016 02:36:27 +0000 [thread overview]
Message-ID: <20161211023620.GL1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20161210204145.GK2622@veci.piliscsaba.szeredi.hu>
On Sat, Dec 10, 2016 at 09:41:45PM +0100, Miklos Szeredi wrote:
> Hi Al,
>
> Please pull from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git readlink
>
> This is a rework of the readlink cleanup patchset. Now readlink(2) does the
> following:
>
> - if i_op->readlink() is non-NULL (only proc and afs mountpoints for now) then
> it calls that;
> - otherwise call i_op->get_link();
> - signature of ->readlink() now matches that of ->get_link();
>
> This is against the #misc branch (the stats look better that way ;)
I'm still not sure what does "vfs: convert ->readlink to same signature as
->get_link" buy us. If anything, the result appears to be more complex -
you make freeing that buffer delayed (and introduce a dynamically allocated
buffer in one case that didn't use it)...
next prev parent reply other threads:[~2016-12-11 2:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-10 20:41 [GIT PULL] readlink cleanup Miklos Szeredi
2016-12-11 2:36 ` Al Viro [this message]
2016-12-11 2:39 ` Al Viro
2016-12-11 10:01 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161211023620.GL1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).