From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f42.google.com ([74.125.83.42]:34214 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752387AbcLSCvQ (ORCPT ); Sun, 18 Dec 2016 21:51:16 -0500 Received: by mail-pg0-f42.google.com with SMTP id y62so2996761pgy.1 for ; Sun, 18 Dec 2016 18:51:16 -0800 (PST) Date: Sun, 18 Dec 2016 17:51:11 -0900 From: Kent Overstreet To: Josef Bacik Cc: "linux-fsdevel@vger.kernel.org" , "david@fromorbit.com" , "hch@lst.de" Subject: Re: Simulating disk failure with a writeback cache Message-ID: <20161219025111.g2nayb3xtxvfbasu@kmo-pixel> References: <20161215022621.kvzga5my7bavxvli@kmo-pixel> <079409FD-B1CB-460B-AA1E-77EF0107B424@fb.com> <20161218201253.wv4bsheg4ook4bdx@kmo-pixel> <1482093534.17731.1@smtp.office365.com> <20161218204623.gea7u4d3pb7k3zhw@kmo-pixel> <05A4E7E7-E733-4AE9-BDC7-FEE9F66E387D@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <05A4E7E7-E733-4AE9-BDC7-FEE9F66E387D@fb.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Sun, Dec 18, 2016 at 09:19:57PM +0000, Josef Bacik wrote: > Eeesh these are older than I thought, I pushed to > https://github.com/josefbacik/fstests.git. The fsx work is there and is > generic, the fsstress one has some btrfs specific stuff but you can just pull > that crap out and it'll work on anything. Let me know if you need anything > else, thanks, Thanks I got your first fsx based test up and running, but - did you get it to pass with any existing filesystems? I finally figured out what I'm seeing, in _check_files() where it's looping over the mark: I changed it to so that it always checks the fsync marks in the order where it was created, but when it goes to check the very first mark it's getting the very last version of the file (at least, the file size is consistent with that). I just pushed what I'm working off of, but I don't think it's anything I broke... https://evilpiepirate.org/git/xfstests.git