From: Eric Biggers <ebiggers3@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Linux Filesystem Development List <linux-fsdevel@vger.kernel.org>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] fscrypt: fix the test_dummy_encryption mount option
Date: Wed, 28 Dec 2016 15:27:59 -0600 [thread overview]
Message-ID: <20161228212759.GC8557@zzz> (raw)
In-Reply-To: <20161228005147.751-1-tytso@mit.edu>
Hi Ted,
On Tue, Dec 27, 2016 at 07:51:47PM -0500, Theodore Ts'o wrote:
> Commit f1c131b45410a: "crypto: xts - Convert to skcipher" now fails
> the setkey operation if the AES key is the same as the tweak key.
> Previously this check was only done if FIPS mode is enabled. Now this
> check is also done if weak key checking was requested. This is
> reasonable, but since we were using the dummy key which was a constant
> series of 0x42 bytes, it now caused dummy encrpyption test mode to
> fail.
>
> Fix this by using 0x42... and 0x24... for the two keys, so they are
> different.
>
This problem would also be fixed by my patch to make the test_dummy_encryption
encryption keys go through the regular keyring lookup and key derivation paths,
which IMO is a better solution long-term:
fscrypt / ext4: make test_dummy_encryption require a keyring key
and corresponding xfstests-bld patch:
xfstests-bld: populate keyring with default key for test_dummy_encryption
Would it make any sense to apply those patches instead?
I'd also be okay with your patch for 4.10 and mine for 4.11 or something like
that.
Eric
next prev parent reply other threads:[~2016-12-28 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 0:51 [PATCH] fscrypt: fix the test_dummy_encryption mount option Theodore Ts'o
2016-12-28 21:27 ` Eric Biggers [this message]
2016-12-29 0:45 ` Theodore Ts'o
2016-12-29 1:01 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228212759.GC8557@zzz \
--to=ebiggers3@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).