From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.136]:58248 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757671AbdADCEO (ORCPT ); Tue, 3 Jan 2017 21:04:14 -0500 Date: Tue, 3 Jan 2017 17:55:10 -0800 From: Jaegeuk Kim To: Yunlong Song Cc: cm224.lee@samsung.com, yuchao0@huawei.com, chao@kernel.org, sylinux@163.com, bintian.wang@huawei.com, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] f2fs: fix small discards when se->valid_blocks is zero Message-ID: <20170104015510.GB16504@jaegeuk.local> References: <1483434117-24427-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1483434117-24427-1-git-send-email-yunlong.song@huawei.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Yunlong, On 01/03, Yunlong Song wrote: > In the small discard case, when se->valid_blocks is zero, the add_discard_addrs > will directly return without __add_discard_entry. This will cause the file > delete have no small discard. The case is like this: > > 1. Allocate free 2M segment > 2. Write a file (size n blocks < 512) in that 2M segment, se->valid_blocks = n > 3. Delete that file, se->valid_blocks = 0, add_discard_addrs will return without > sending any discard of that file, and forever due to cur_map[i] ^ ckpt_map[i] = > 0 after that checkpoint During this checkpoint, that'll be discarded as a prefree segment, no? Note that, if this is a current segment, f2fs won't discard it until it is fully allocated. Thanks, > > Signed-off-by: Yunlong Song > --- > fs/f2fs/segment.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c > index 0738f48..8610f14 100644 > --- a/fs/f2fs/segment.c > +++ b/fs/f2fs/segment.c > @@ -838,7 +838,7 @@ static void add_discard_addrs(struct f2fs_sb_info *sbi, struct cp_control *cpc) > return; > > if (!force) { > - if (!test_opt(sbi, DISCARD) || !se->valid_blocks || > + if (!test_opt(sbi, DISCARD) || > SM_I(sbi)->nr_discards >= SM_I(sbi)->max_discards) > return; > } > -- > 1.8.5.2