linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] fscrypt: remove unused 'mode' member of fscrypt_ctx
@ 2017-01-05 20:01 Eric Biggers
  2017-01-08  6:09 ` Theodore Ts'o
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Biggers @ 2017-01-05 20:01 UTC (permalink / raw)
  To: linux-fsdevel; +Cc: Theodore Ts'o, Jaegeuk Kim, Eric Biggers

From: Eric Biggers <ebiggers@google.com>

Nothing reads or writes fscrypt_ctx.mode, and it doesn't belong there
because a fscrypt_ctx is not tied to a specific encryption mode.

Signed-off-by: Eric Biggers <ebiggers@google.com>
---
 include/linux/fscrypto.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/fscrypto.h b/include/linux/fscrypto.h
index 2a2815702095..8635ea46ef6e 100644
--- a/include/linux/fscrypto.h
+++ b/include/linux/fscrypto.h
@@ -35,7 +35,6 @@ struct fscrypt_ctx {
 		struct list_head free_list;	/* Free list */
 	};
 	u8 flags;				/* Flags */
-	u8 mode;				/* Encryption mode for tfm */
 };
 
 /**
-- 
2.11.0.390.gc69c2f50cf-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] fscrypt: remove unused 'mode' member of fscrypt_ctx
  2017-01-05 20:01 [PATCH] fscrypt: remove unused 'mode' member of fscrypt_ctx Eric Biggers
@ 2017-01-08  6:09 ` Theodore Ts'o
  0 siblings, 0 replies; 2+ messages in thread
From: Theodore Ts'o @ 2017-01-08  6:09 UTC (permalink / raw)
  To: Eric Biggers; +Cc: linux-fsdevel, Jaegeuk Kim, Eric Biggers

On Thu, Jan 05, 2017 at 12:01:30PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
> 
> Nothing reads or writes fscrypt_ctx.mode, and it doesn't belong there
> because a fscrypt_ctx is not tied to a specific encryption mode.
> 
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Thanks, applied.

				- Ted

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-01-08  6:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-05 20:01 [PATCH] fscrypt: remove unused 'mode' member of fscrypt_ctx Eric Biggers
2017-01-08  6:09 ` Theodore Ts'o

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).