From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f65.google.com ([74.125.83.65]:35734 "EHLO mail-pg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1034629AbdAFAKB (ORCPT ); Thu, 5 Jan 2017 19:10:01 -0500 Received: by mail-pg0-f65.google.com with SMTP id i5so42150832pgh.2 for ; Thu, 05 Jan 2017 16:10:01 -0800 (PST) Date: Thu, 5 Jan 2017 16:09:59 -0800 From: Eric Biggers To: Richard Weinberger Cc: linux-fsdevel@vger.kernel.org, Theodore Ts'o , Jaegeuk Kim , Eric Biggers Subject: Re: [PATCH] fscrypt: constify struct fscrypt_operations Message-ID: <20170106000959.GA49081@gmail.com> References: <20170105204243.79135-1-ebiggers3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, Jan 06, 2017 at 01:03:33AM +0100, Richard Weinberger wrote: > Am 05.01.2017 um 21:42 schrieb Eric Biggers: > > From: Eric Biggers > > > > Signed-off-by: Eric Biggers > > --- > > fs/ext4/super.c | 4 ++-- > > fs/f2fs/super.c | 4 ++-- > > fs/ubifs/crypto.c | 2 +- > > fs/ubifs/super.c | 2 +- > > fs/ubifs/ubifs.h | 2 +- > > 5 files changed, 7 insertions(+), 7 deletions(-) > > Reviewed-by: Richard Weinberger > > Eric, I assume you did also a build test with UBIFS enabled, right? > Constifying stuff often looks easy but can uncover horrors. ;D > Yes, I compiled with ext4, f2fs, and ubifs enabled, both with and without encryption enabled for each filesystem. Eric