From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:46205 "EHLO mga11.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1759907AbdAJToK (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Tue, 10 Jan 2017 14:44:10 -0500
Date: Tue, 10 Jan 2017 12:44:08 -0700
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
        Theodore Ts'o <tytso@mit.edu>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Matthew Wilcox <willy@linux.intel.com>,
        Jan Kara <jack@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>,
        Dave Chinner <dchinner@redhat.com>,
        Dan Williams <dan.j.williams@intel.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dax: try to avoid unused function warnings
Message-ID: <20170110194408.GA14287@linux.intel.com>
References: <20161128211233.2446605-1-arnd@arndb.de>
 <20161128212400.GA16225@linux.intel.com>
 <1946137.McqY686LOu@wuerfel>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1946137.McqY686LOu@wuerfel>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Tue, Jan 10, 2017 at 05:15:57PM +0100, Arnd Bergmann wrote:
> On Monday, November 28, 2016 2:24:00 PM CET Ross Zwisler wrote:
> > On Mon, Nov 28, 2016 at 10:12:17PM +0100, Arnd Bergmann wrote:
> > > Without the get_block based I/O, we get warnings when CONFIG_FS_IOMAP
> > > is disabled:
> > > 
> > > fs/dax.c:736:12: error: ‘dax_insert_mapping’ defined but not used [-Werror=unused-function]
> > > fs/dax.c:512:12: error: ‘copy_user_dax’ defined but not used [-Werror=unused-function]
> > > fs/dax.c:490:12: error: ‘dax_load_hole’ defined but not used [-Werror=unused-function]
> > > fs/dax.c:294:14: error: ‘grab_mapping_entry’ defined but not used [-Werror=unused-function]
> > > 
> > > This patch blindly marks those as __maybe_unused, which avoids the warnings.
> > > However, I suspect that there is actually more code in this file that should
> > > not be provided without CONFIG_FS_IOMAP even though we don't get a warning
> > > for it, and that we actually want a different rework, so please treat this
> > > as a bug report. I have applied the patch locally in my randconfig build
> > > setup to avoid seeing the warnings.
> > > 
> > > Fixes: 5ac65736f740 ("dax: rip out get_block based IO support")
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > 
> > Thanks for the report.  I think the right way to deal with this is to just
> > select FS_IOMAP when we pull in the DAX code.  I sent out a patch last week
> > that does this:
> > 
> > https://lkml.org/lkml/2016/11/23/591
> 
> It seems we never got agreement on the approach, and we still get the
> warnings above in v4.10. Should we use my patch to fix up 4.10 and get
> a clean build again? It no longer applies, but I have a rebased version
> that I can send.
> 
> 	Arnd

Thanks for the reminder, this one slipped through the cracks.  I still think
the right way to go with this is to fix up DAX's dependence on FS_IOMAP.  I'll
send out an updated patch.