From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailrelay118.isp.belgacom.be ([195.238.20.145]:53961 "EHLO mailrelay118.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751187AbdASUmY (ORCPT ); Thu, 19 Jan 2017 15:42:24 -0500 From: Fabian Frederick To: Jan Kara Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, fabf@skynet.be Subject: [PATCH 1/1 linux-next] udf: return inappropriate ioctl instead of argument error Date: Thu, 19 Jan 2017 21:41:37 +0100 Message-Id: <20170119204137.31158-1-fabf@skynet.be> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Currently, lsattr for instance in udf directory gives "udf: Invalid argument While reading flags on ..." This patch removes argument testing and returns -ENOIOCTLCMD when command is unknown to have more accurate message like this: "Inappropriate ioctl for device While reading flags on ..." If arg is NULL, we return specific operation error anyway. Signed-off-by: Fabian Frederick --- fs/udf/file.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fs/udf/file.c b/fs/udf/file.c index dbcb3a4a..964620b 100644 --- a/fs/udf/file.c +++ b/fs/udf/file.c @@ -184,12 +184,6 @@ long udf_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) goto out; } - if (!arg) { - udf_debug("invalid argument to udf_ioctl\n"); - result = -EINVAL; - goto out; - } - switch (cmd) { case UDF_GETVOLIDENT: if (copy_to_user((char __user *)arg, @@ -220,6 +214,8 @@ long udf_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) UDF_I(inode)->i_ext.i_data, UDF_I(inode)->i_lenEAttr) ? -EFAULT : 0; goto out; + default: + return -ENOIOCTLCMD; } out: -- 2.9.3