* [patch] fs/affs: affs_bread() doesn't return ERR_PTRs
@ 2017-01-21 4:48 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2017-01-21 4:48 UTC (permalink / raw)
To: Andrew Morton, Fabian Frederick
Cc: Al Viro, Jan Kara, Boaz Harrosh, Miklos Szeredi, linux-fsdevel,
kernel-janitors
We're checking IS_ERR() here, but we should be checking for NULL.
Fixes: e393e82a7d09 ("fs/affs: make export work with cold dcache")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/affs/namei.c b/fs/affs/namei.c
index a3df8a6..706dd06 100644
--- a/fs/affs/namei.c
+++ b/fs/affs/namei.c
@@ -453,8 +453,8 @@ static struct dentry *affs_get_parent(struct dentry *child)
struct buffer_head *bh;
bh = affs_bread(child->d_sb, d_inode(child)->i_ino);
- if (IS_ERR(bh))
- return ERR_CAST(bh);
+ if (bh)
+ return ERR_PTR(-EIO);
parent = affs_iget(child->d_sb,
be32_to_cpu(AFFS_TAIL(child->d_sb, bh)->parent));
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2017-01-21 4:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-21 4:48 [patch] fs/affs: affs_bread() doesn't return ERR_PTRs Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).