From: Dan Carpenter <dan.carpenter@oracle.com>
To: Mike Marshall <hubcap@omnibond.com>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] orangefs: Dan Carpenter influenced cleanups...
Date: Tue, 7 Feb 2017 11:35:43 +0300 [thread overview]
Message-ID: <20170207083543.GF11103@mwanda> (raw)
In-Reply-To: <20170206162120.16717-1-hubcap@omnibond.com>
On Mon, Feb 06, 2017 at 11:21:20AM -0500, Mike Marshall wrote:
> @@ -996,7 +996,7 @@ int orangefs_debugfs_new_client_string(void __user *arg)
> if (orangefs_prepare_debugfs_help_string(0)) {
> gossip_err("%s: no debug help string \n",
> __func__);
> - return -EIO;
> + return -EFAULT;
> }
The rest looks nice but -EFAULT isn't right here. It should propogate
the return from orangefs_prepare_debugfs_help_string().
ret = orangefs_prepare_debugfs_help_string(0);
if (ret) {
gossip_err("%s: no debug help string \n",
__func__);
return ret;
}
regards,
dan carpenter
next prev parent reply other threads:[~2017-02-07 8:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-06 16:21 [PATCH] orangefs: Dan Carpenter influenced cleanups Mike Marshall
2017-02-07 8:35 ` Dan Carpenter [this message]
2017-02-07 13:16 ` Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170207083543.GF11103@mwanda \
--to=dan.carpenter@oracle.com \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).