From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:41790 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932294AbdBHH7f (ORCPT ); Wed, 8 Feb 2017 02:59:35 -0500 Date: Tue, 7 Feb 2017 23:59:30 -0800 From: Christoph Hellwig To: Goldwyn Rodrigues Cc: linux-fsdevel@vger.kernel.org, Goldwyn Rodrigues Subject: Re: [PATCH] aio: Check for aio_flags Message-ID: <20170208075930.GA32505@infradead.org> References: <20170208023323.8962-1-rgoldwyn@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170208023323.8962-1-rgoldwyn@suse.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, Feb 07, 2017 at 08:33:23PM -0600, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > aio_flags are not checked when performing io_submit() and > can contain non-conforming values. > Return -EINVAL if they are invalid. while this is what we should have done from the start it could break existing userspace programs now.