From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@lst.de>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-nvdimm@lists.01.org, Ted Tso <tytso@mit.edu>
Subject: Re: [PATCH 1/2] ext4: fix DAX write locking
Date: Wed, 8 Feb 2017 09:14:10 -0800 [thread overview]
Message-ID: <20170208171410.GA27359@infradead.org> (raw)
In-Reply-To: <20170111090136.GE16116@quack2.suse.cz>
On Wed, Jan 11, 2017 at 10:01:36AM +0100, Jan Kara wrote:
> On Tue 10-01-17 16:48:07, Christoph Hellwig wrote:
> > Unlike O_DIRECT DAX is not an optional opt-in feature selected by the
> > application, so we'll have to provide the traditional synchronіzation
> > of overlapping writes as we do for buffered writes.
> >
> > This was broken historically for DAX, but got fixed for ext2 and XFS
> > as part of the iomap conversion. Fix up ext4 as well.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Makes sense. You can add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
> Ted, can you please pick it up? Thanks!
Did this get picked up?
next prev parent reply other threads:[~2017-02-08 17:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 15:48 fix write synchronization for DAX Christoph Hellwig
2017-01-10 15:48 ` [PATCH 1/2] ext4: fix DAX write locking Christoph Hellwig
2017-01-11 9:01 ` Jan Kara
2017-02-08 17:14 ` Christoph Hellwig [this message]
2017-02-08 19:38 ` Theodore Ts'o
2017-02-08 19:41 ` Theodore Ts'o
2017-01-10 15:48 ` [PATCH 2/2] dax: assert that i_rwsem is held exclusive for writes Christoph Hellwig
2017-01-11 9:02 ` Jan Kara
2017-02-08 19:43 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208171410.GA27359@infradead.org \
--to=hch@infradead.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).