From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([65.50.211.133]:57979 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbdBHRgt (ORCPT ); Wed, 8 Feb 2017 12:36:49 -0500 Date: Wed, 8 Feb 2017 09:14:10 -0800 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, Ted Tso Subject: Re: [PATCH 1/2] ext4: fix DAX write locking Message-ID: <20170208171410.GA27359@infradead.org> References: <1484063288-18255-1-git-send-email-hch@lst.de> <1484063288-18255-2-git-send-email-hch@lst.de> <20170111090136.GE16116@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170111090136.GE16116@quack2.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Jan 11, 2017 at 10:01:36AM +0100, Jan Kara wrote: > On Tue 10-01-17 16:48:07, Christoph Hellwig wrote: > > Unlike O_DIRECT DAX is not an optional opt-in feature selected by the > > application, so we'll have to provide the traditional synchronŃ–zation > > of overlapping writes as we do for buffered writes. > > > > This was broken historically for DAX, but got fixed for ext2 and XFS > > as part of the iomap conversion. Fix up ext4 as well. > > > > Signed-off-by: Christoph Hellwig > > Makes sense. You can add: > > Reviewed-by: Jan Kara > > Ted, can you please pick it up? Thanks! Did this get picked up?