From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f66.google.com ([74.125.83.66]:35925 "EHLO mail-pg0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbdBIC4M (ORCPT ); Wed, 8 Feb 2017 21:56:12 -0500 Received: by mail-pg0-f66.google.com with SMTP id 75so16508562pgf.3 for ; Wed, 08 Feb 2017 18:55:24 -0800 (PST) Date: Thu, 9 Feb 2017 10:55:23 +0800 From: Eryu Guan To: Theodore Ts'o Cc: Al Viro , "Eric W. Biederman" , Maxim Patlasov , linux-fsdevel@vger.kernel.org, Zorro Lang Subject: Re: Does anyone have test cases for mount namespaces? Message-ID: <20170209025523.GC1946@eguan.usersys.redhat.com> References: <20170208231330.534fg6naiefldw6f@thunk.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170208231330.534fg6naiefldw6f@thunk.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Ted, On Wed, Feb 08, 2017 at 06:13:30PM -0500, Theodore Ts'o wrote: > Hi, > > I'm trying to backport a security fix involving the mount namespaces > (in fs/pnode.c), and I'm wondering if anyone has a set of sanity > checks (ideally in the form of a shell script) which they use to make > sure nothing has broken with respect to mount --make-shared, et. al. > > I've really gotten spoiled with xfstests, and the mount namespaces > code looks subtle and quick to anger, and I'd prefer to have something > more substantial than "It builds! Release it to production!" :-) AFAIK, there's a test script from LTP does some mount namespace function and regression tests, e.g. --bind --make-private --make-shared --move $LTP_SOURCE/testscripts/test_fs_bind.sh And Zorro Lang has proposed some mount tests[1] for xfstests last May, but the tests never got reviewed & merged (hope they can be reviewed & committed by this opportunity :). Thanks, Eryu [1] https://www.spinics.net/lists/fstests/msg03029.html