Re: [PATCHv6 08/37] filemap: handle huge pages in do_generic_file_read()

Matthew Wilcox
2017-02-13T16:01:17Z

On Mon, Feb 13, 2017 at 06:33:42PM +0300, Kirill A. Shutemov wrote:
> No. pagecache_get_page() returns subpage. See description of the first
> patch.

Your description says:

> We also change interface for page-cache lookup function:
>
> - functions that lookup for pages[1] would return subpages of THP
> relevant for requested indexes;
>
> - functions that lookup for entries[2] would return one entry per-THP
> and index will point to index of head page (basically, round down to
> HPAGE_PMD_NR);
>
> This would provide balanced exposure of multi-order entires to the rest
> of the kernel.
>
> [1] find_get_pages(), pagecache_get_page(), pagevec_lookup(), etc.
> [2] find_get_entry(), find_get_entries(), pagevec_lookup_entries(), etc.

I'm saying:

> > We got this page from find_get_page(), which gets it from
> > pagecache_get_page(), which gets it from find_get_entry() ... which
> > (unless I'm lost in your patch series) returns the head page.

Am I guilty of debugging documentation rather than code?