From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] vfs: fix uninitialized flags in splice_to_pipe()
Date: Mon, 20 Feb 2017 01:20:36 -0800 [thread overview]
Message-ID: <20170220092036.GB5664@infradead.org> (raw)
In-Reply-To: <20170216164902.GC30656@veci.piliscsaba.szeredi.hu>
On Thu, Feb 16, 2017 at 05:49:02PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@redhat.com>
>
> Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the unused
> part of the pipe ring buffer. Previously splice_to_pipe() left the flags
> value alone, which could result in incorrect behavior.
>
> Uninitialized flags appears to have been there from the introduction of the
> splice syscall.
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
prev parent reply other threads:[~2017-02-20 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 16:49 [PATCH] vfs: fix uninitialized flags in splice_to_pipe() Miklos Szeredi
2017-02-20 9:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220092036.GB5664@infradead.org \
--to=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).