linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Yunlong Song <yunlong.song@huawei.com>
Cc: cm224.lee@samsung.com, yuchao0@huawei.com, chao@kernel.org,
	sylinux@163.com, miaoxie@huawei.com, bintian.wang@huawei.com,
	linux-fsdevel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] f2fs: clean up codes in get_ssr_segment
Date: Wed, 22 Feb 2017 16:41:14 -0800	[thread overview]
Message-ID: <20170223004114.GF4003@jaegeuk.local> (raw)
In-Reply-To: <1487767851-819-1-git-send-email-yunlong.song@huawei.com>

Hi Yunlong,

This is NOT clean-up. What's your point here?

Thanks,

On 02/22, Yunlong Song wrote:
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
>  fs/f2fs/segment.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index df2ff5c..80997f5 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -1541,7 +1541,7 @@ static int get_ssr_segment(struct f2fs_sb_info *sbi, int type)
>  	struct curseg_info *curseg = CURSEG_I(sbi, type);
>  	const struct victim_selection *v_ops = DIRTY_I(sbi)->v_ops;
>  
> -	if (IS_NODESEG(type) || !has_not_enough_free_secs(sbi, 0, 0))
> +	if (IS_NODESEG(type))
>  		return v_ops->get_victim(sbi,
>  				&(curseg)->next_segno, BG_GC, type, SSR);
>  
> -- 
> 1.8.5.2

  parent reply	other threads:[~2017-02-23  0:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-22 12:50 [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Yunlong Song
2017-02-22 12:50 ` [PATCH 2/3] f2fs: provide more chance to get node ssr Yunlong Song
2017-02-22 12:50 ` [PATCH 3/3] f2fs: provide more chance for node and data to get ssr segment Yunlong Song
2017-02-23  1:17   ` Jaegeuk Kim
2017-02-23  2:13     ` Yunlong Song
2017-02-23  2:41       ` Yunlong Song
2017-02-24  9:05     ` Chao Yu
2017-02-24  9:19       ` Yunlong Song
2017-02-24 10:47         ` Chao Yu
2017-02-24 11:41           ` Yunlong Song
2017-02-24 17:58             ` Jaegeuk Kim
     [not found]               ` <b5c6b4d.d7.15a7177d92d.Coremail.sylinux@163.com>
2017-02-24 20:05                 ` Jaegeuk Kim
2017-02-25  2:16                   ` Yunlong Song
2017-02-23  0:41 ` Jaegeuk Kim [this message]
2017-02-23  0:59   ` [PATCH 1/3] f2fs: clean up codes in get_ssr_segment Jaegeuk Kim
2017-02-23  1:55     ` Yunlong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170223004114.GF4003@jaegeuk.local \
    --to=jaegeuk@kernel.org \
    --cc=bintian.wang@huawei.com \
    --cc=chao@kernel.org \
    --cc=cm224.lee@samsung.com \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miaoxie@huawei.com \
    --cc=sylinux@163.com \
    --cc=yuchao0@huawei.com \
    --cc=yunlong.song@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).