From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from merlin.infradead.org ([205.233.59.134]:58668 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751268AbdBXQlS (ORCPT ); Fri, 24 Feb 2017 11:41:18 -0500 Message-Id: <20170224162043.922049726@infradead.org> Date: Fri, 24 Feb 2017 16:43:30 +0100 From: Peter Zijlstra To: Al Viro , Linus Torvalds , Chris Mason Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, David Howells , elena.reshetova@intel.com, ishkamiel@gmail.com, dwindsor@gmail.com, gregkh@linuxfoundation.org, peterz@infradead.org Subject: [RFC][PATCH 01/10] fs: Use lockdep_assert_held() instead of comments References: <20170224154329.478276481@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline; filename=peterz-fs-inode-1.patch Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Because nobody reads comments... Signed-off-by: Peter Zijlstra (Intel) --- fs/inode.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) --- a/fs/inode.c +++ b/fs/inode.c @@ -384,11 +384,9 @@ static void init_once(void *foo) inode_init_once(inode); } -/* - * inode->i_lock must be held - */ void __iget(struct inode *inode) { + lockdep_assert_held(&inode->i_lock); atomic_inc(&inode->i_count); } @@ -409,11 +407,10 @@ static void inode_lru_list_add(struct in /* * Add inode to LRU if needed (inode is unused and clean). - * - * Needs inode->i_lock held. */ void inode_add_lru(struct inode *inode) { + lockdep_assert_held(&inode->i_lock); if (!(inode->i_state & (I_DIRTY_ALL | I_SYNC | I_FREEING | I_WILL_FREE)) && !atomic_read(&inode->i_count) && inode->i_sb->s_flags & MS_ACTIVE)