From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrei Vagin <avagin@virtuozzo.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-api@vger.kernel.org, viro@zeniv.linux.org.uk,
akpm@linuxfoundation.org, xemul@virtuozzo.com,
mtk.manpages@gmail.com, kir@openvz.org, luto@amacapital.net,
jbaron@akamai.com, Andrey Vagin <avagin@openvz.org>
Subject: Re: [RFC 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files
Date: Tue, 28 Feb 2017 09:53:06 +0300 [thread overview]
Message-ID: <20170228065306.GH22938@uranus> (raw)
In-Reply-To: <20170227224346.GA7101@outlook.office365.com>
On Mon, Feb 27, 2017 at 02:43:47PM -0800, Andrei Vagin wrote:
...
> > +
> > + if (filp1 && filp_epoll) {
> > + filp_tgt = get_epoll_tfile_raw_ptr(filp_epoll, slot.tfd, slot.toff);
> > + if (IS_ERR(filp_tgt))
> > + ret = PTR_ERR(filp_tgt);
> > + else
> > + ret = kcmp_ptr(filp1, filp_tgt, KCMP_EPOLL_TFD);
>
> I think KCMP_FILE has to be used here ^^^^, because we compare files. We
> have to use the same function for all files to be able to sort them, don't we?
Yes. I already have v2 in my queue. Strictly speaking we can use separate
salt here but it will be waste of memory from userspace POV. I didn't send
v2 yet since I'm modifying criu still to test overall picture. Hopefully
will send today.
next prev parent reply other threads:[~2017-02-28 6:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 16:59 [RFC 2/3] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files Cyrill Gorcunov
2017-02-27 22:43 ` Andrei Vagin
2017-02-28 6:53 ` Cyrill Gorcunov [this message]
2017-02-28 17:12 ` [RFC v2 " Cyrill Gorcunov
2017-03-01 23:05 ` Andrei Vagin
2017-03-02 7:32 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170228065306.GH22938@uranus \
--to=gorcunov@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=avagin@openvz.org \
--cc=avagin@virtuozzo.com \
--cc=jbaron@akamai.com \
--cc=kir@openvz.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).