linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] fs/libfs: use SEEK_CUR/SET
@ 2017-02-28 19:45 Tomohiro Kusumi
  2017-02-28 19:45 ` [PATCH 2/3] nfs: " Tomohiro Kusumi
  2017-02-28 19:45 ` [PATCH 3/3] fs/mpage: fix a comment "get_blocks" to "get_block" Tomohiro Kusumi
  0 siblings, 2 replies; 3+ messages in thread
From: Tomohiro Kusumi @ 2017-02-28 19:45 UTC (permalink / raw)
  To: viro, linux-fsdevel, trond.myklebust, anna.schumaker, linux-nfs
  Cc: Tomohiro Kusumi

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 fs/libfs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/libfs.c b/fs/libfs.c
index 28d6f35..cb03444 100644
--- a/fs/libfs.c
+++ b/fs/libfs.c
@@ -143,9 +143,9 @@ loff_t dcache_dir_lseek(struct file *file, loff_t offset, int whence)
 {
 	struct dentry *dentry = file->f_path.dentry;
 	switch (whence) {
-		case 1:
+		case SEEK_CUR:
 			offset += file->f_pos;
-		case 0:
+		case SEEK_SET:
 			if (offset >= 0)
 				break;
 		default:
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/3] nfs: use SEEK_CUR/SET
  2017-02-28 19:45 [PATCH 1/3] fs/libfs: use SEEK_CUR/SET Tomohiro Kusumi
@ 2017-02-28 19:45 ` Tomohiro Kusumi
  2017-02-28 19:45 ` [PATCH 3/3] fs/mpage: fix a comment "get_blocks" to "get_block" Tomohiro Kusumi
  1 sibling, 0 replies; 3+ messages in thread
From: Tomohiro Kusumi @ 2017-02-28 19:45 UTC (permalink / raw)
  To: viro, linux-fsdevel, trond.myklebust, anna.schumaker, linux-nfs
  Cc: Tomohiro Kusumi

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 fs/nfs/dir.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index fad8104..95712e1 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -972,9 +972,9 @@ static loff_t nfs_llseek_dir(struct file *filp, loff_t offset, int whence)
 			filp, offset, whence);
 
 	switch (whence) {
-		case 1:
+		case SEEK_CUR:
 			offset += filp->f_pos;
-		case 0:
+		case SEEK_SET:
 			if (offset >= 0)
 				break;
 		default:
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 3/3] fs/mpage: fix a comment "get_blocks" to "get_block"
  2017-02-28 19:45 [PATCH 1/3] fs/libfs: use SEEK_CUR/SET Tomohiro Kusumi
  2017-02-28 19:45 ` [PATCH 2/3] nfs: " Tomohiro Kusumi
@ 2017-02-28 19:45 ` Tomohiro Kusumi
  1 sibling, 0 replies; 3+ messages in thread
From: Tomohiro Kusumi @ 2017-02-28 19:45 UTC (permalink / raw)
  To: viro, linux-fsdevel, trond.myklebust, anna.schumaker, linux-nfs
  Cc: Tomohiro Kusumi

It's a get_block_t argument get_block being called here.

Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
---
 fs/mpage.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/mpage.c b/fs/mpage.c
index 28af984..67e9492 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -173,7 +173,7 @@ do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages,
 	page_block = 0;
 
 	/*
-	 * Map blocks using the result from the previous get_blocks call first.
+	 * Map blocks using the result from the previous get_block call first.
 	 */
 	nblocks = map_bh->b_size >> blkbits;
 	if (buffer_mapped(map_bh) && block_in_file > *first_logical_block &&
@@ -197,7 +197,7 @@ do_mpage_readpage(struct bio *bio, struct page *page, unsigned nr_pages,
 	}
 
 	/*
-	 * Then do more get_blocks calls until we are done with this page.
+	 * Then do more get_block calls until we are done with this page.
 	 */
 	map_bh->b_page = page;
 	while (page_block < blocks_per_page) {
-- 
2.9.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-28 20:29 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-28 19:45 [PATCH 1/3] fs/libfs: use SEEK_CUR/SET Tomohiro Kusumi
2017-02-28 19:45 ` [PATCH 2/3] nfs: " Tomohiro Kusumi
2017-02-28 19:45 ` [PATCH 3/3] fs/mpage: fix a comment "get_blocks" to "get_block" Tomohiro Kusumi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).