From: Christoph Hellwig <hch@infradead.org>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: jack@suse.com, hch@infradead.org, linux-fsdevel@vger.kernel.org,
linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
Goldwyn Rodrigues <rgoldwyn@suse.com>
Subject: Re: [PATCH 7/8] nowait aio: xfs
Date: Wed, 1 Mar 2017 07:40:58 -0800 [thread overview]
Message-ID: <20170301154058.GD30631@infradead.org> (raw)
In-Reply-To: <20170228233610.25456-8-rgoldwyn@suse.de>
> @@ -528,12 +528,17 @@ xfs_file_dio_aio_write(
> ((iocb->ki_pos + count) & mp->m_blockmask)) {
> unaligned_io = 1;
> iolock = XFS_IOLOCK_EXCL;
> + if (iocb->ki_flags & IOCB_NOWAIT)
> + return -EAGAIN;
So all unaligned I/O will return -EAGAIN? Why? Also please explain
that reason in a comment right here.
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 1aa3abd..84f981a 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -1020,6 +1020,11 @@ xfs_file_iomap_begin(
> if ((flags & IOMAP_REPORT) ||
> (xfs_is_reflink_inode(ip) &&
> (flags & IOMAP_WRITE) && (flags & IOMAP_DIRECT))) {
> + /* Allocations due to reflinks */
> + if ((flags & IOMAP_NOWAIT) && !(flags & IOMAP_REPORT)) {
> + error = -EAGAIN;
> + goto out_unlock;
> + }
FYI, this code looks very different in current Linus' tree - I think
you're on some old kernel base.
next prev parent reply other threads:[~2017-03-01 15:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 23:36 [PATCH 0/8 v2] Non-blocking AIO Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 1/8] nowait aio: Introduce IOCB_FLAG_NOWAIT Goldwyn Rodrigues
2017-03-01 15:36 ` Christoph Hellwig
2017-03-01 15:56 ` Christoph Hellwig
2017-03-01 16:57 ` Goldwyn Rodrigues
2017-03-01 22:44 ` Christoph Hellwig
2017-02-28 23:36 ` [PATCH 2/8] nowait aio: Return if cannot get hold of i_rwsem Goldwyn Rodrigues
2017-03-01 15:37 ` Christoph Hellwig
2017-02-28 23:36 ` [PATCH 3/8] nowait aio: return if direct write will trigger writeback Goldwyn Rodrigues
2017-03-01 3:46 ` Matthew Wilcox
2017-03-01 15:38 ` Christoph Hellwig
2017-03-02 10:38 ` Jan Kara
2017-03-02 14:12 ` Matthew Wilcox
2017-03-02 15:22 ` Jan Kara
2017-02-28 23:36 ` [PATCH 4/8] nowait aio: Introduce IOMAP_NOWAIT Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 5/8] nowait aio: return on congested block device Goldwyn Rodrigues
2017-03-08 7:03 ` Sagi Grimberg
2017-03-08 15:00 ` Goldwyn Rodrigues
2017-03-08 15:28 ` Jan Kara
2017-03-08 15:51 ` Christoph Hellwig
2017-03-08 16:17 ` Jens Axboe
2017-03-09 2:18 ` Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 6/8] nowait aio: ext4 Goldwyn Rodrigues
2017-02-28 23:36 ` [PATCH 7/8] nowait aio: xfs Goldwyn Rodrigues
2017-03-01 15:40 ` Christoph Hellwig [this message]
2017-02-28 23:36 ` [PATCH 8/8] nowait aio: btrfs Goldwyn Rodrigues
2017-03-05 14:56 ` [PATCH 0/8 v2] Non-blocking AIO Avi Kivity
2017-03-06 8:25 ` Jan Kara
2017-03-06 8:40 ` Avi Kivity
2017-03-06 15:19 ` Jens Axboe
2017-03-06 15:29 ` Avi Kivity
2017-03-06 15:38 ` Jens Axboe
2017-03-06 15:59 ` Avi Kivity
2017-03-06 16:08 ` Jens Axboe
2017-03-06 16:59 ` Avi Kivity
2017-03-06 17:06 ` Jens Axboe
2017-03-06 18:17 ` Avi Kivity
2017-03-06 18:27 ` Jens Axboe
2017-03-06 18:50 ` Avi Kivity
-- strict thread matches above, loose matches on Subject: below --
2017-03-15 21:50 [PATCH 0/8 v3] No wait AIO Goldwyn Rodrigues
2017-03-15 21:51 ` [PATCH 7/8] nowait aio: xfs Goldwyn Rodrigues
2017-04-03 18:52 [PATCH 0/8 v4] No wait AIO Goldwyn Rodrigues
2017-04-03 18:53 ` [PATCH 7/8] nowait aio: xfs Goldwyn Rodrigues
2017-04-04 6:52 ` Christoph Hellwig
2017-04-06 22:54 ` Darrick J. Wong
2017-04-07 11:34 ` Goldwyn Rodrigues
2017-04-07 15:08 ` Darrick J. Wong
2017-04-14 12:02 [PATCH 0/8 v6] No wait AIO Goldwyn Rodrigues
2017-04-14 12:02 ` [PATCH 7/8] nowait aio: xfs Goldwyn Rodrigues
2017-04-19 6:45 ` Christoph Hellwig
2017-05-09 12:22 [PATCH 0/8 v7] No wait AIO Goldwyn Rodrigues
2017-05-09 12:22 ` [PATCH 7/8] nowait aio: xfs Goldwyn Rodrigues
2017-05-11 7:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301154058.GD30631@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=rgoldwyn@suse.com \
--cc=rgoldwyn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).