From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:39548 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbdCIG7K (ORCPT ); Thu, 9 Mar 2017 01:59:10 -0500 Date: Thu, 9 Mar 2017 14:59:08 +0800 From: Eryu Guan To: David Howells Cc: Christoph Hellwig , mtk.manpages@gmail.com, "Darrick J. Wong" , linux-fsdevel , xfs Subject: Re: statx manpage Message-ID: <20170309065908.GI14226@eguan.usersys.redhat.com> References: <20170308034500.GY14226@eguan.usersys.redhat.com> <20170307050140.GA12946@infradead.org> <20170307000609.GG5280@birch.djwong.org> <10435.1488907375@warthog.procyon.org.uk> <21188.1489042008@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <21188.1489042008@warthog.procyon.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Mar 09, 2017 at 06:46:48AM +0000, David Howells wrote: > Eryu Guan wrote: > > > There's a "ADDING TO THE FSQA SUITE" section in README file, basically > > it's telling you to use './new' script to generate new test template. So > > based on what type of new test you're going to create, you could run: > > > > ./new generic # new generic test > > ./new xfs # new xfs test > > ./new ext4 # new ext4 test > > ./new shared # new shared test > > ... > > > > It finds the first free seq number and creates test template and a > > default .out file in tests/ dir and add a new entry in > > tests//group file. You could just edit the template and update > > the .out file with expected output from the test run. > > Yes, I'd spotted the ./new script, but it's not as simple as that since shell > scripts can't call system calls directly. A normal way we take for fstests is adding new syscall support to xfs_io first, then writing new tests based on it, as some other new syscalls/utilities do, e.g. set|get_encpolicy were added to xfs_io in January to set|get encryption policy for ext4 encryption testing. Thanks, Eryu