From: "hch@infradead.org" <hch@infradead.org>
To: Olga Kornievskaia <kolga@netapp.com>
Cc: "hch@infradead.org" <hch@infradead.org>,
"bfields@fieldses.org" <bfields@fieldses.org>,
Trond Myklebust <trondmy@primarydata.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC v1 01/19] fs: Don't copy beyond the end of the file
Date: Thu, 9 Mar 2017 13:55:56 -0800 [thread overview]
Message-ID: <20170309215556.GA22756@infradead.org> (raw)
In-Reply-To: <480EF075-69E6-458D-AA5F-FBE19F68C3C3@netapp.com>
On Thu, Mar 09, 2017 at 12:28:03PM -0500, Olga Kornievskaia wrote:
> I’m confused by the wording of “we can do … easily” . Is “can” = in the future? Currently, testing copy_file_range() on a btfs with argument of offset+len beyond the end of the file fail with EINVAL. Is NFS tweaking = revert the “MUST” in the spec for the check?
The current clone and copy documents (which are our specs) require
this behavior, so that is expected. But if we decided we want a variant
of copy / clone that doesn't do this it would be very easy to implement
in the local file systems. Only for NFS we'd get a failure back and
would have to retry the clone based on the updated file size.
next prev parent reply other threads:[~2017-03-09 22:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170302160123.30375-1-kolga@netapp.com>
[not found] ` <20170302160123.30375-2-kolga@netapp.com>
[not found] ` <20170302162221.GA6854@infradead.org>
[not found] ` <20170303204747.GE13877@fieldses.org>
[not found] ` <4B2A2E86-AFC8-49EA-9D53-7A53AD824CF1@netapp.com>
[not found] ` <20170303213230.GF13877@fieldses.org>
[not found] ` <B3F80DA0-B4F8-4628-88C5-E5C047620F17@netapp.com>
[not found] ` <20170304021008.GB21609@fieldses.org>
[not found] ` <924FF7A2-27CD-4848-BD61-748758C2533F@netapp.com>
2017-03-06 19:23 ` [RFC v1 01/19] Don't copy beyond the end of the file J. Bruce Fields
2017-03-07 14:18 ` Olga Kornievskaia
[not found] ` <20170307234051.GA29977@infradead.org>
[not found] ` <20170308170521.GA1020@fieldses.org>
[not found] ` <20170308172549.GA32011@infradead.org>
[not found] ` <7FDA8E80-3C62-48BB-9E2B-195B4BA340C0@netapp.com>
2017-03-08 19:53 ` [RFC v1 01/19] fs: " J. Bruce Fields
2017-03-08 20:00 ` Olga Kornievskaia
2017-03-08 20:18 ` J. Bruce Fields
2017-03-08 20:18 ` Trond Myklebust
2017-03-08 20:32 ` bfields
2017-03-08 20:49 ` Trond Myklebust
2017-03-09 15:29 ` bfields
2017-03-09 15:35 ` hch
2017-03-09 16:16 ` bfields
2017-03-09 16:17 ` hch
2017-03-09 17:28 ` Olga Kornievskaia
2017-03-09 18:40 ` bfields
2017-03-09 21:55 ` hch [this message]
2017-03-09 17:35 ` Olga Kornievskaia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170309215556.GA22756@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=kolga@netapp.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).